Skip to content

feat: api serve#98

Merged
abemedia merged 1 commit into
masterfrom
feat/api-serve
May 7, 2023
Merged

feat: api serve#98
abemedia merged 1 commit into
masterfrom
feat/api-serve

Conversation

@abemedia

@abemedia abemedia commented May 7, 2023

Copy link
Copy Markdown
Owner

No description provided.

@codecov

codecov Bot commented May 7, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage: 14.28% and project coverage change: -0.31 ⚠️

Comparison is base (0bf9383) 83.97% compared to head (a4efb8c) 83.67%.

❗ Current head a4efb8c differs from pull request most recent head 0e5f9aa. Consider uploading reports for the commit 0e5f9aa to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
- Coverage   83.97%   83.67%   -0.31%     
==========================================
  Files          19       19              
  Lines         774      772       -2     
==========================================
- Hits          650      646       -4     
- Misses         98      100       +2     
  Partials       26       26              
Impacted Files Coverage Δ
api.go 80.82% <14.28%> (-3.18%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions

github-actions Bot commented May 7, 2023

Copy link
Copy Markdown
Contributor

Benchmark Result

Benchmark diff with base branch
goos: linux
goarch: amd64
pkg: github.com/abemedia/go-don
cpu: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz
          │ bench-master.txt │           bench-new.txt            │
          │      sec/op      │   sec/op     vs base               │
Handler-2        456.9n ± 0%   458.8n ± 0%  +0.40% (p=0.004 n=10)

          │ bench-master.txt │         bench-new.txt          │
          │       B/op       │    B/op     vs base            │
Handler-2         72.00 ± 0%   72.00 ± 0%  ~ (p=1.000 n=10) ¹
¹ all samples are equal

          │ bench-master.txt │         bench-new.txt          │
          │    allocs/op     │ allocs/op   vs base            │
Handler-2         2.000 ± 0%   2.000 ± 0%  ~ (p=1.000 n=10) ¹
¹ all samples are equal

pkg: github.com/abemedia/go-don/decoder
                    │ bench-master.txt │           bench-new.txt            │
                    │      sec/op      │   sec/op     vs base               │
Decoder/Gorilla-2          19.36µ ± 0%   19.32µ ± 1%  -0.20% (p=0.050 n=10)
Decoder/DonCached-2        963.7n ± 1%   967.2n ± 1%       ~ (p=0.383 n=10)
Decoder/Don-2              1.010µ ± 1%   1.018µ ± 1%  +0.74% (p=0.011 n=10)
geomean                    2.661µ        2.669µ       +0.30%

                    │ bench-master.txt │             bench-new.txt             │
                    │       B/op       │     B/op      vs base                 │
Decoder/Gorilla-2         2.500Ki ± 0%   2.500Ki ± 0%       ~ (p=1.000 n=10) ¹
Decoder/DonCached-2         176.0 ± 0%     176.0 ± 0%       ~ (p=1.000 n=10) ¹
Decoder/Don-2               176.0 ± 0%     176.0 ± 0%       ~ (p=1.000 n=10) ¹
geomean                     429.6          429.6       +0.00%
¹ all samples are equal

                    │ bench-master.txt │            bench-new.txt            │
                    │    allocs/op     │ allocs/op   vs base                 │
Decoder/Gorilla-2           166.0 ± 0%   166.0 ± 0%       ~ (p=1.000 n=10) ¹
Decoder/DonCached-2         3.000 ± 0%   3.000 ± 0%       ~ (p=1.000 n=10) ¹
Decoder/Don-2               3.000 ± 0%   3.000 ± 0%       ~ (p=1.000 n=10) ¹
geomean                     11.43        11.43       +0.00%
¹ all samples are equal
Benchmark result
goos: linux
goarch: amd64
pkg: github.com/abemedia/go-don
cpu: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz
          │ bench-new.txt │
          │    sec/op     │
Handler-2     458.8n ± 0%

          │ bench-new.txt │
          │     B/op      │
Handler-2      72.00 ± 0%

          │ bench-new.txt │
          │   allocs/op   │
Handler-2      2.000 ± 0%

pkg: github.com/abemedia/go-don/decoder
                    │ bench-new.txt │
                    │    sec/op     │
Decoder/Gorilla-2       19.32µ ± 1%
Decoder/DonCached-2     967.2n ± 1%
Decoder/Don-2           1.018µ ± 1%
geomean                 2.669µ

                    │ bench-new.txt │
                    │     B/op      │
Decoder/Gorilla-2      2.500Ki ± 0%
Decoder/DonCached-2      176.0 ± 0%
Decoder/Don-2            176.0 ± 0%
geomean                  429.6

                    │ bench-new.txt │
                    │   allocs/op   │
Decoder/Gorilla-2        166.0 ± 0%
Decoder/DonCached-2      3.000 ± 0%
Decoder/Don-2            3.000 ± 0%
geomean                  11.43

@abemedia abemedia enabled auto-merge (squash) May 7, 2023 10:54
@abemedia abemedia merged commit 602b24c into master May 7, 2023
@abemedia abemedia deleted the feat/api-serve branch May 7, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant