-
Notifications
You must be signed in to change notification settings - Fork 229
Closed
Labels
enhancementNew feature or requestNew feature or request
Description
This is already packaged in nixpkgs. But there are some things that would make maintaining the Nix package for this easier:
- Way of disabling updating through app without modifying the source code
- Way of disabling downloading ytdlp without modifying the source code
- Have a consistent way of getting ffmpeg location. Currently in
Lines 3 to 16 in 6b494ef
let ffmpeg = ""; if (os.platform() === "win32") { ffmpeg = `"${__dirname}\\..\\ffmpeg.exe"`; } else if (os.platform() === "freebsd") { try { ffmpeg = cp.execSync("which ffmpeg").toString("utf8").split("\n")[0].trim(); } catch (error) { console.log(error) showPopup("No ffmpeg found in PATH."); } } else { ffmpeg = `"${__dirname}/../ffmpeg"`; } Lines 49 to 64 in 6b494ef
if (!fs.existsSync(ffmpegPath)) { try { if (os.platform() === "win32") { ffmpeg = execSync("where ffmpeg.exe", {encoding: "utf8"}); console.log({ffmpeg}) ffmpeg = `"${ffmpeg.trimEnd()}"`; } else { ffmpeg = execSync("which ffmpeg", {encoding: "utf8"}); ffmpeg = `"${ffmpeg.trimEnd()}"`; } } catch (error) { ffmpeg = `""` console.log(error); } } console.log("ffmpeg:", ffmpeg);
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request