feat: add ember-vite example

[Nsttt]

No description provided.

[claude]

Claude finished @Nsttt's task —— View job

---

PR Review Complete ✅

I've conducted a thorough code review of the ember-vite example addition and provided comprehensive feedback.

Completed Tasks:

• Create pending GitHub review
• Get PR diff to understand changes and line numbers
• Analyze package.json and dependencies for security issues
• Review configuration files for best practices
• Examine application code structure and quality
• Check test coverage and test quality
• Add inline review comments for specific issues
• Submit comprehensive review with overall assessment

Review Summary

Overall Quality Score: 6/10

Key Findings:

• ✅ Excellent Vite integration and modern Ember setup
• ⚠️ Critical: No test files present despite test infrastructure
• ⚠️ High: Beta dependencies may cause stability/security issues
• ⚠️ Missing production security configuration
• ✅ Good code quality and modern patterns

Priority Actions:

1. Add sample test files to demonstrate testing with Vite
2. Replace beta versions with stable releases
3. Complete metadata and documentation accuracy

The PR provides a solid foundation for an Ember-Vite example but needs test coverage and stability improvements before being production-ready. I've added specific inline comments and recommendations throughout the codebase.

---

[claude]

Comprehensive Code Review: Ember-Vite Example

Purpose Summary: This PR adds a complete Ember.js application example configured to use Vite as the build tool, demonstrating modern Ember development with Vite integration.

Detailed Review Analysis

Review Summary Table

Severity	Line(s)	Issue	Recommendation
High	package.json:56,65	Beta versions in dependencies	Use stable releases for ember-cli and ember-source
Critical	tests/ directory	Missing test files	Add sample integration and unit tests
Medium	package.json:5-8	Missing metadata	Complete description, repository, author fields
Medium	README.md:43	Incorrect build command	Update build commands for Vite workflow
Medium	environment.js:43	Empty production config	Add security headers and production optimizations
Low	vite.config.mjs:10	Unclear comment	Remove or improve plugin comment
Low	application.gjs:5	Hardcoded app title	Use descriptive or configurable title

Security Analysis

• ✅ No direct security vulnerabilities found in code
• ⚠️ Beta versions could introduce unknown security issues
• ⚠️ Missing CSP and security headers configuration
• ✅ Dependencies appear legitimate and from trusted sources
• ✅ No secrets or sensitive data exposed

Performance Considerations

• ✅ Vite configuration is appropriate for fast development
• ✅ Modern ES modules and tree-shaking enabled
• ✅ Babel configuration optimized for runtime transforms
• ✅ Proper asset handling through Embroider/Vite integration

Code Quality Assessment

• ✅ ESLint configuration is comprehensive with modern standards
• ✅ Prettier and Stylelint properly configured
• ✅ Modern Ember patterns (GJS templates, Octane edition)
• ⚠️ Missing actual implementation examples beyond welcome page
• ⚠️ No demonstration of Ember features (components, services, routes)

Test Coverage Analysis

• ❌ Critical Gap: No actual test files present
• ✅ Test infrastructure properly configured (QUnit, ember-qunit)
• ✅ Test helper setup is correct
• ❌ Missing integration tests for key functionality
• ❌ No unit tests for components or services

Architecture & Design

• ✅ Proper Embroider/Vite integration
• ✅ Modern Ember application structure
• ✅ Appropriate separation of concerns
• ✅ Configuration files well-organized
• ⚠️ Could benefit from more example components/features

Concrete Fixes

For package.json stability:

{
  "ember-cli": "~6.4.0",
  "ember-source": "~6.4.0"
}

For production security (environment.js):

if (environment === 'production') {
  ENV.APP.rootURL = '/ember-vite/'; // if needed for deployment
  // Add security configurations
  ENV.contentSecurityPolicy = {
    'default-src': "'self'",
    'script-src': "'self'",
    'style-src': "'self' 'unsafe-inline'"
  };
}

Sample test file (tests/integration/components/application-test.js):

import { module, test } from 'qunit';
import { setupRenderingTest } from 'ember-qunit';
import { render } from '@ember/test-helpers';
import { hbs } from 'ember-cli-htmlbars';

module('Integration | Component | application', function (hooks) {
  setupRenderingTest(hooks);

  test('it renders welcome page', async function (assert) {
    await render(hbs`<WelcomePage />`);
    assert.dom('[data-test-welcome]').exists();
  });
});

Overall Quality Score: 6/10

Scoring Breakdown:

• Setup & Configuration: 8/10 (excellent Vite integration)
• Code Quality: 7/10 (good patterns, needs more examples)
• Security: 5/10 (beta deps, missing security config)
• Test Coverage: 2/10 (infrastructure only, no tests)
• Documentation: 6/10 (good structure, some inaccuracies)
• Best Practices: 7/10 (modern patterns, some gaps)

Top 3 Next Steps:

1. Add comprehensive test coverage - Create sample integration and unit tests to demonstrate testing with Vite
2. Stabilize dependencies - Replace beta versions with stable releases for production readiness
3. Enhance example content - Add more Ember components and features to better demonstrate the framework capabilities

This is a solid foundation for an Ember-Vite example, but addressing the test coverage and stability issues would significantly improve its value as a reference implementation.

[claude]

High Priority - Security: Using beta versions in production examples could introduce instability and security vulnerabilities. Consider using stable versions for ember-cli (currently ~6.5.0-beta.0) and ember-source (currently ~6.5.0-beta.1).

[claude]

Medium Priority - Metadata: The package.json is missing important metadata fields like description, repository, and author. For an example project in a public repository, these should be properly filled out to demonstrate best practices.

[claude]

Medium Priority - Documentation: The build command shown here is incorrect for the Vite setup. Line 43 shows npm exec ember build which doesn't align with the Vite configuration. Should use npm run build for production builds as shown in line 44, or update the development build command to match the Vite workflow.

[claude]

Low Priority - Code Quality: The comment "extra plugins here" should either be removed if no additional plugins are intended, or replaced with a more descriptive comment about what types of plugins might be added here for customization.

[claude]

Low Priority - Best Practice: The pageTitle is hardcoded as "MyApp". For an example project, this should either be more descriptive (e.g., "Ember Vite Example") or demonstrate how to make it configurable through environment variables or configuration.

[claude]

Medium Priority - Security: Consider adding basic security headers configuration for production environment. The current production configuration is empty but should include security best practices like CSP headers, HSTS, etc., especially for an example that others might use as a template.