-
Notifications
You must be signed in to change notification settings - Fork 16
feat: add rsbuild docs #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Claude finished @Nsttt's task —— View job Comprehensive PR ReviewNote: Writing Todo List:
Purpose Summary: This PR adds comprehensive Rsbuild integration documentation for Zephyr Cloud, including setup instructions, Module Federation support, and configuration examples. Review FindingsIssues and Recommendations
Code Quality AssessmentStrengths:
Areas for Improvement:
// Remove these unused imports:
import SupportedBrowser from "../../components/browser-table";
import { DrawingPinIcon } from '@radix-ui/react-icons';
import { Image } from "../../components/ui/image";
import { Keyboard } from "../../components/ui/keyboard";
import { SourceCode } from '@theme';
import { Tabs, TabsContent, TabsList, TabsTrigger } from "../../components/ui/tabs";
import { Card } from "../../components/ui/card";
// Current:
remotes: {
remote: 'remote@http://localhost:3001/remoteEntry.js',
},
// Better:
remotes: {
remote: 'remote@https://your-remote-app.com/remoteEntry.js',
// or use environment variable example
remote: `remote@${process.env.REMOTE_URL}/remoteEntry.js`,
},
// Current:
withZephyr({
wait_for_index_html: true,
})
// Better:
withZephyr({
waitForIndexHtml: true,
}) Security Review
Performance Considerations
Test Coverage
Overall Quality Score: 8.5/10 This is a high-quality addition to the documentation that follows established patterns and provides comprehensive guidance for Rsbuild integration. The documentation is well-structured, clear, and includes all necessary setup steps. Top 3 Next Steps:
The PR is ready for merge after addressing these minor cleanup items. The core functionality and documentation quality are excellent. |
What's added in this PR?
Add rsbuild docs for rsbuild plugin. Related ZephyrCloudIO/zephyr-packages#197
(Required) Pre-PR/Merge checklist