change(deps): Allow zebra-rpc to be compiled without protoc - #9819
Merged
Conversation
…put dir instead of re-compiling them if `protoc` is not available - Adds proto files to `zebra-rpc/proto/__generated__`
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
Author
|
@Mergifyio update |
Contributor
✅ Branch has been successfully updated |
conradoplg
previously approved these changes
Aug 28, 2025
conradoplg
left a comment
conradoplg
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, just needs conflict solving
nuttycom
reviewed
Aug 29, 2025
nuttycom
reviewed
Aug 29, 2025
…if the proto files are absent
conradoplg
previously approved these changes
Sep 2, 2025
conradoplg
left a comment
conradoplg
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, but more conflicts 😅
oxarbitrage
reviewed
Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This has been requested.
Closes #9817.
Solution
zebra-rpc/build.rsto:zebra-rpc/proto/__generated__ifprotocis available, orzebra-rpc/proto/__generated__into output directory otherwisezebra-rpc/proto/__generated__Tests
Manually tested.
Follow-up Work
Release a new patch version of
zebra-rpcPR Checklist