change(build): Adds prometheus as a default feature in zebrad - #9677
Merged
Conversation
…etrics endpoint config field in `entrypoint.sh`.
conradoplg
previously approved these changes
Jul 2, 2025
conradoplg
approved these changes
Jul 3, 2025
conradoplg
left a comment
conradoplg
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, but I don't really get why that fix was needed 🤔
Contributor
Author
The crates were being used directly (with qualifiers) in tests behind the feature. |
aphelionz
pushed a commit
to ShieldedLabs/zebra-crosslink
that referenced
this pull request
Aug 12, 2025
…hFoundation#9677) * adds `prometheus` to `default` zebrad feature, adds a commented out metrics endpoint config field in `entrypoint.sh`. * fixes test compilation and clippy warnings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #9158.
Solution
prometheusto the list of default features inzebrad, andmetrics.endpoint_addrto the docker configPR Checklist