feat(rpc): add value pools to getblock

[conradoplg]

Motivation

We want to fill the valuePools and chainSupply fields for the getblock RPC.

Solution

The database part was included in #9539, I'll leave its description below for the record.

That requires keeping track of the value pools after each block; we only keep it for the entire chain.

This PR introduces a new column family named block_data. The idea behind the generic name is that we could add other data there like chainwork and block size. In fact, the main reason this is a draft PR is because we might want to add those in the same PR, but I'd like to get feedback on this first.

The database upgrade is slow (main reason) and takes ~2h to complete (it was 4h, I managed to improve a bit with rayon). I think this is harmless since it only impacts the RPC itself (it does not return the field if the data is not yet available).

To avoid a circular dependency, this also moves some subsidy-related functions from zebra-consensus to zebra-chain. I'm not sure if I should go ahead and move everything else related to that. Let me know if you prefer a separate PR with the move, but I also wanted feedback on this first.

Closes #5449

Tests

I adjusted the existing tests and used zcash-rpc-diff to compare with zcashd, and everything seems to match (with this exception)

Specifications & References

https://github.com/zcash/zcash/blob/99ad6fdc3a549ab510422820eea5e5ce9f60a5fd/src/rpc/blockchain.cpp#L766-L782

Follow-up Work

PR Checklist

• The PR name is suitable for the release notes.
• The solution is tested.
• The documentation is up to date.
• The PR has a priority label.
• If the PR shouldn't be in the release notes, it has the
  C-exclude-from-changelog label.

[dismad]

Is there a way to show the status of the valuePool sync? That might be useful to add if it doesn't complicate things.

I'm thinking in getinfo or getblockchaininfo a `isValuePoolsSynced' boolean, or even better, a % complete

[conradoplg]

Is there a way to show the status of the valuePool sync? That might be useful to add if it doesn't complicate things.

I'm thinking in getinfo or getblockchaininfo a `isValuePoolsSynced' boolean, or even better, a % complete

I think it would be work that will be rarely used, since after the database is upgraded you'll never have to worry about it again. You can somewhat check the progress by calling getblock for some height and checking if it returns the pools

[conradoplg]

Moved to draft because @arya2 will try combining this and #9295

[mpguerra]

@conradoplg can we close this one in favour of @arya2 's PR?

[conradoplg]

@conradoplg can we close this one in favour of @arya2 's PR?

I thin I'll repurpose it to contain the RPC call itself based on @arya2 's PR (which contains the DB changes but not the RPC change itself IIRC)

[conradoplg]

@Mergifyio update

[mergify]

update

✅ Branch has been successfully updated

[conradoplg]

@arya2 review reminder 🙏

[arya2]

This looks good, I left some comments but none of them are blockers.

[mpguerra]

@Mergifyio queue

[mergify]

queue

✅ The pull request has been merged automatically

Details

The pull request has been merged automatically at 9caa717