Skip to content

change(state): Add an init function for a standalone ReadStateService - #8595

Merged
mergify[bot] merged 5 commits into
mainfrom
init-read-state
Jun 12, 2024
Merged

change(state): Add an init function for a standalone ReadStateService#8595
mergify[bot] merged 5 commits into
mainfrom
init-read-state

Conversation

@arya2

@arya2 arya2 commented Jun 7, 2024

Copy link
Copy Markdown
Contributor

Motivation

We want a function for initializing a ReadStateService

Closes #8520.

PR Author Checklist

Check before marking the PR as ready for review:

  • Will the PR name make sense to users?
  • Does the PR have a priority label?
  • Have you added or updated tests?
  • Is the documentation up to date?
For significant changes:
  • Is there a summary in the CHANGELOG?
  • Can these changes be split into multiple PRs?

If a checkbox isn't relevant to the PR, mark it as done.

Solution

  • Adds init_read_only() and spawn_init_read_only() functions to zebra-state

Testing

Zebra already uses a read-only version of ZebraDb in the scanning results reader binary.

Review

Anyone can review.

Reviewer Checklist

Check before approving the PR:

  • Does the PR scope match the ticket?
  • Are there enough tests to make sure it works? Do the tests cover the PR motivation?
  • Are all the PR blockers dealt with?
    PR blockers can be dealt with in new tickets or PRs.

And check the PR Author checklist is complete.

@arya2 arya2 self-assigned this Jun 7, 2024
@arya2
arya2 marked this pull request as ready for review June 10, 2024 19:38
@arya2
arya2 requested a review from a team as a code owner June 10, 2024 19:38
@arya2
arya2 requested review from upbqdn and removed request for a team June 10, 2024 19:38

@oxarbitrage oxarbitrage left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and it is working for me, thanks!

mergify Bot added a commit that referenced this pull request Jun 12, 2024
@mergify
mergify Bot merged commit 1b5f942 into main Jun 12, 2024
@mergify
mergify Bot deleted the init-read-state branch June 12, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

Add an init function for a standalone ReadStateService

2 participants