Skip to content

add(consensus): Add slow_start_{interval/shift} fields to testnet::Parameters - #8477

Merged
mergify[bot] merged 2 commits into
mainfrom
params-slow-start-interval
May 8, 2024
Merged

add(consensus): Add slow_start_{interval/shift} fields to testnet::Parameters#8477
mergify[bot] merged 2 commits into
mainfrom
params-slow-start-interval

Conversation

@arya2

@arya2 arya2 commented Apr 30, 2024

Copy link
Copy Markdown
Contributor

Motivation

This PR adds fields to testnet::Parameters and is cleanup for #8475.

Part of #7119.

Depends-On: #8475.

PR Author Checklist

Check before marking the PR as ready for review:

  • Will the PR name make sense to users?
  • Does the PR have a priority label?
  • Have you added or updated tests?
  • Is the documentation up to date?
For significant changes:
  • Is there a summary in the CHANGELOG?
  • Can these changes be split into multiple PRs?

If a checkbox isn't relevant to the PR, mark it as done.

Solution

  • Adds slow_start_interval and slow_start_shift fields to testnet::Parameters
  • Moves SLOW_START_INTERVAL and SLOW_START_SHIFT constants to zebra-chain

Testing

The new_regtest() method should be tested by regtest_submit_blocks(), some of the rest should be covered by existing tests, there may be a minor gap in coverage considering a mistake was made in the previous PR.

Review

Anyone can review.

Reviewer Checklist

Check before approving the PR:

  • Does the PR scope match the ticket?
  • Are there enough tests to make sure it works? Do the tests cover the PR motivation?
  • Are all the PR blockers dealt with?
    PR blockers can be dealt with in new tickets or PRs.

And check the PR Author checklist is complete.

@arya2 arya2 added consensus Consensus-critical code: validation, cryptography, script C-cleanup Category: This is a cleanup NU-6 P-Medium ⚡ labels Apr 30, 2024
@arya2 arya2 self-assigned this Apr 30, 2024
@arya2
arya2 requested a review from a team as a code owner April 30, 2024 23:22
@arya2
arya2 requested review from oxarbitrage and removed request for a team April 30, 2024 23:22
@arya2 arya2 added this to the Regtest Network support milestone May 1, 2024
Base automatically changed from params-regtest to main May 2, 2024 19:43
@mergify
mergify Bot requested review from a team as code owners May 2, 2024 19:43
@mergify
mergify Bot requested review from upbqdn and removed request for a team May 2, 2024 19:43
@upbqdn

upbqdn commented May 2, 2024

Copy link
Copy Markdown
Member

@arya, this PR needs a manual conflict resolution.

@mpguerra mpguerra linked an issue May 3, 2024 that may be closed by this pull request
5 tasks
@arya2
arya2 force-pushed the params-slow-start-interval branch from 6fa0e51 to 5ea89e3 Compare May 3, 2024 16:13
@arya2 arya2 added do-not-merge Tells Mergify not to merge this PR P-Medium ⚡ and removed P-Critical 🚑 labels May 3, 2024
@arya2
arya2 force-pushed the params-slow-start-interval branch from 5ea89e3 to 9bde989 Compare May 3, 2024 16:45
- Moves SLOW_START_INTERVAL/SLOW_START_SHIFT constants to zebra-chain
@arya2
arya2 force-pushed the params-slow-start-interval branch from 9bde989 to 5b33680 Compare May 3, 2024 18:08
upbqdn
upbqdn previously approved these changes May 6, 2024
Comment thread zebra-chain/src/parameters/network/testnet.rs Outdated
Comment thread zebra-consensus/src/block/subsidy/general.rs Outdated
@oxarbitrage oxarbitrage removed the do-not-merge Tells Mergify not to merge this PR label May 7, 2024
Co-authored-by: Marek <mail@marek.onl>
@arya2
arya2 requested a review from upbqdn May 8, 2024 14:53
mergify Bot added a commit that referenced this pull request May 8, 2024
@mergify
mergify Bot merged commit d2d1a18 into main May 8, 2024
@mergify
mergify Bot deleted the params-slow-start-interval branch May 8, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-cleanup Category: This is a cleanup consensus Consensus-critical code: validation, cryptography, script P-Medium ⚡

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tracking: Enable short-chain single-node network for testing purposes

3 participants