add(consensus): Add slow_start_{interval/shift} fields to testnet::Parameters - #8477
Merged
Conversation
Member
|
@arya, this PR needs a manual conflict resolution. |
5 tasks
arya2
force-pushed
the
params-slow-start-interval
branch
from
May 3, 2024 16:13
6fa0e51 to
5ea89e3
Compare
arya2
force-pushed
the
params-slow-start-interval
branch
from
May 3, 2024 16:45
5ea89e3 to
9bde989
Compare
- Moves SLOW_START_INTERVAL/SLOW_START_SHIFT constants to zebra-chain
arya2
force-pushed
the
params-slow-start-interval
branch
from
May 3, 2024 18:08
9bde989 to
5b33680
Compare
upbqdn
previously approved these changes
May 6, 2024
Co-authored-by: Marek <mail@marek.onl>
oxarbitrage
approved these changes
May 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR adds fields to
testnet::Parametersand is cleanup for #8475.Part of #7119.
Depends-On: #8475.
PR Author Checklist
Check before marking the PR as ready for review:
For significant changes:
If a checkbox isn't relevant to the PR, mark it as done.
Solution
slow_start_intervalandslow_start_shiftfields totestnet::ParametersSLOW_START_INTERVALandSLOW_START_SHIFTconstants to zebra-chainTesting
The
new_regtest()method should be tested byregtest_submit_blocks(), some of the rest should be covered by existing tests, there may be a minor gap in coverage considering a mistake was made in the previous PR.Review
Anyone can review.
Reviewer Checklist
Check before approving the PR:
PR blockers can be dealt with in new tickets or PRs.
And check the PR Author checklist is complete.