Skip to content

fix(ci): Accept Cargo features for Docker release builds - #10075

Merged
mergify[bot] merged 1 commit into
mainfrom
fix-docker-features
Nov 12, 2025
Merged

fix(ci): Accept Cargo features for Docker release builds#10075
mergify[bot] merged 1 commit into
mainfrom
fix-docker-features

Conversation

@upbqdn

@upbqdn upbqdn commented Nov 11, 2025

Copy link
Copy Markdown
Member

Motivation

Tests

The logs for

docker build -f ./docker/Dockerfile --target runtime --build-arg FEATURES="internal-miner" --tag z .
docker run --rm z

show that the non-default feature is active at Zebra's startup.

PR Checklist

  • The PR name is suitable for the release notes.
  • The PR follows the contribution guidelines.
  • The library crate changelogs are up to date.
  • The solution is tested.
  • The documentation is up to date.

@upbqdn upbqdn self-assigned this Nov 11, 2025
@upbqdn upbqdn added C-bug Category: This is a bug devops Build, CI, test infrastructure, release process labels Nov 11, 2025
@github-actions github-actions Bot added the C-feature Category: New features label Nov 11, 2025
@mergify

mergify Bot commented Nov 11, 2025

Copy link
Copy Markdown
Contributor

鈿狅笍 The sha of the head commit of this PR conflicts with #10007. Mergify cannot evaluate rules on this PR. 鈿狅笍

@upbqdn
upbqdn marked this pull request as draft November 11, 2025 09:32
@upbqdn
upbqdn force-pushed the fix-docker-features branch from 63719f8 to d79f771 Compare November 11, 2025 09:38
@upbqdn
upbqdn marked this pull request as ready for review November 11, 2025 15:02
@gustavovalverde

Copy link
Copy Markdown
Member

@upbqdn The diff seems to be including things from:

@upbqdn

upbqdn commented Nov 12, 2025

Copy link
Copy Markdown
Member Author

Should be fixed.

@gustavovalverde gustavovalverde left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify Bot added the queued label Nov 12, 2025
@mergify
mergify Bot merged commit 903dab2 into main Nov 12, 2025
39 checks passed
@mergify
mergify Bot deleted the fix-docker-features branch November 12, 2025 11:26
@mergify mergify Bot removed the queued label Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-bug Category: This is a bug C-feature Category: New features devops Build, CI, test infrastructure, release process

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dockerfile ignores Cargo features for release builds

2 participants