fix: z_validateaddress bug - #10022
Merged
mergify[bot] merged 1 commit intoOct 28, 2025
Merged
Conversation
27 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When receiving a regtest t-address in
z_validateaddressit fails because it is parsing it as a testnet address, even when running on regtest. This mismatch makes the endpoint return an "invalid" response, when it should be valid.Solution
If Zebra receives a t-address and the network is not mainnet, we treat regtest as equal to testnet.
Tests
Added
rpc_z_validateaddress_regtestfor testing this scenario.Specifications & References
We're implementing this endpoint on Zaino here, and we encountered this issue there too.
The presence of this bug was previously discussed here.
Follow-up Work
PR Checklist