Skip to content

Conversation

NPellet
Copy link
Contributor

@NPellet NPellet commented May 23, 2022

Subtypes of unions should be considered eligible for asTypeAliasRef in getTypeDefinition

e.g.

type A = {
  "prop": string
}

type B = {
  "prop": string,
  "refToA"?: A | null 
}

should return a reference to A when compiled with --aliasRefs

PS: Sorry for the changes introduced by prettier...

@domoritz
Copy link
Collaborator

Thank you. Please remove the npm lock file.

@NPellet
Copy link
Contributor Author

NPellet commented May 23, 2022

Sorry, screwed up my last commit.

Coming up

@domoritz domoritz merged commit 8157a7b into YousefED:master May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants