Add state_dependent_path_declaration so that ifnone can be parsed
#5121
Conversation
| @@ -6,7 +6,7 @@ GENFILES += frontends/verilog/verilog_lexer.cc | |||
|
|
|||
| frontends/verilog/verilog_parser.tab.cc: frontends/verilog/verilog_parser.y | |||
| $(Q) mkdir -p $(dir $@) | |||
| $(P) $(BISON) -Wall -Werror -o $@ -d -r all -b frontends/verilog/verilog_parser $< | |||
| $(P) $(BISON) -Wall -Wcex -Werror -o $@ -d -r all -b frontends/verilog/verilog_parser $< | |||
There was a problem hiding this comment.
From https://www.gnu.org/software/bison/manual/html_node/Diagnostics.html:
cex
Provide counterexamples for conflicts. See Generation of Counterexamples. Counterexamples take time to compute. The option -Wcex should be used by the developer when working on the grammar; it hardly makes sense to use it in a CI.
I don't think this should be included.
| module_path_expression: | ||
| module_path_primary | ||
| // Flatten out unary_operator to avoid shift/reduce conflict | ||
| | '!' attr module_path_primary { delete $2; } |
There was a problem hiding this comment.
Based on the existing code, these need to be freeattr($2); instead to avoid a memory leak (not that I'm sure why they're being deleted).
|
Also could you please add test(s) for the |
|
Hi, I really appreciate this fix. I just ran in the same issue as #5092 when I tried to read in the IHP stdcells as blackboxes. @FlinkbaumFAU, do you still intend to finish it? |
|
Hi, |
|
Thanks a lot! Yes, it's just a matter of time until someone else stumbles across this issue :) |
The parser crashed when an
ifnone-statement occured. See Bug #5092 .The
state_dependen_path_declarationfrom the specification was added to the parser file.