Use default storage class #294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that ./variants override with specific storageclasses for cloud providers
solsson
added a commit
to Yolean/ystack
that referenced
this pull request
Oct 27, 2019
through default storage class: Yolean/kubernetes-kafka#294
Empty strings are used for statically provisioned volumes
solsson
added a commit
to Yolean/ystack
that referenced
this pull request
Oct 27, 2019
solsson
added a commit
that referenced
this pull request
Jan 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clusters without a default storage class can get one globally using:
Note that existing statefulsets can't be upgraded with this change. Apply will result in
spec: Forbidden: updates to statefulset spec for fields other than 'replicas', 'template', and 'updateStrategy' are forbidden. When you already have volumes it's better to override storageclass like for example the GKE variant does: https://github.com/Yolean/kubernetes-kafka/blob/v6.0.3/variants/gke-regional/kustomization.yaml#L4 and https://github.com/Yolean/kubernetes-kafka/blob/v6.0.3/variants/gke-regional/gke-storageclass-broker-pd.yaml