Skip to content

Use standard storage class by default, demonstrate kustomization per hosting provider #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
May 6, 2019
Merged

Use standard storage class by default, demonstrate kustomization per hosting provider #270

merged 21 commits into from
May 6, 2019

Conversation

solsson
Copy link
Contributor

@solsson solsson commented May 3, 2019

Fixes #268. Affects #269.

solsson added 13 commits May 3, 2019 08:16
@solsson
Defaults to \”standard" storage class for all persistence
36903cf
@solsson
With the new defaults there'll be no need for minikube storageclasses
8f949e4
@solsson
I haven't used Docker's k8s for a while but
1bf9744 
it too should have a standard storage class
@solsson
Overlays can be based on overlays
5ef2914 
solves the duplication pointed out in #266 870435a
@solsson
Merge branch 'combine-kustomizations' into storagclass-kustomize
ba342ee
@solsson
Includes RBAC in variants
ed0844c 
I haven't seen a non-RBAC cluster in a long time, and the
clusterrole+clusterrolebinding have an origin label
@solsson
Replaces variant as-is with scale-[brokers]-[zks]
44717ce
@solsson
Regional, i.e. multi-zone, volumes for 2 of 5 zk pods is now a variant
d86263f 
For background see #191

Also relevant to #269 #268 #243 #179
@solsson
Updates docs for removal of ./configure and status of apply -f
1d47004 
See also #269
@solsson
Migrates AWS and AKS examples from ./configure to overlays
d168b48
@solsson
Cool
bebd7b8
@solsson
Quickstart shouldn't overwrite anything that exists
553f327
@solsson
Kustomize is a good fit for maintaining a setup over time
02140ec 
as it points out which resources/modules to apply and supports commit-ish refs
@solsson
Copy link
Contributor Author

solsson commented May 3, 2019

I tried adding - github.com/Yolean/kubernetes-kafka/variants/prometheus-operator/?ref=419c629 (from #259) to the sample kustomization in 02140ec but got id '"~G_v1_ConfigMap|kafka|~P|broker-config|~S"' already used. Would be interesting to try after we've merged both to master. Anyhow we should update the refs to v6.0.0 after next release.

@solsson solsson mentioned this pull request May 6, 2019
Closed
@solsson solsson merged commit 85b61f4 into master May 6, 2019
@solsson solsson mentioned this pull request May 10, 2019
Merged
@solsson solsson mentioned this pull request Aug 13, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Storage class kafka-zookeeper-regional is not defined in docker-storageclass-zookeeper.yml
1 participant
@solsson