This repository was archived by the owner on Oct 4, 2022. It is now read-only.
P2 686 render svg icon #1135
Merged
P2 686 render svg icon #1135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andizer
added
innovation
changelog: non-user-facing
hansjovis
suggested changes
Mar 31, 2021
| @@ -87,6 +93,23 @@ export default class BlockDefinition extends Definition { | |||
|
|
|||
| logger.debug( "registering block " + name ); | |||
|
|
|||
| if ( configuration.icon && typeof configuration.icon === "string" && configuration.icon.includes( "<svg" ) ) { | |||
There was a problem hiding this comment.
Perhaps startsWith is a bit more robust for detecting valid svg images:
Suggested change
| if ( configuration.icon && typeof configuration.icon === "string" && configuration.icon.includes( "<svg" ) ) { | |
| if ( configuration.icon && typeof configuration.icon === "string" && configuration.icon.startsWith( "<svg" ) ) { |
Comment on lines
97
to
110
| configuration.icon = createElement( | ||
| BlockIcon, | ||
| { | ||
| icon: createElement( | ||
| "span", | ||
| { | ||
| className: "yoast-schema-blocks-icon", | ||
| dangerouslySetInnerHTML: { | ||
| __html: configuration.icon, | ||
| }, | ||
| }, | ||
| ), | ||
| }, | ||
| ); |
There was a problem hiding this comment.
This could be improved by using JSX:
Suggested change
| configuration.icon = createElement( | |
| BlockIcon, | |
| { | |
| icon: createElement( | |
| "span", | |
| { | |
| className: "yoast-schema-blocks-icon", | |
| dangerouslySetInnerHTML: { | |
| __html: configuration.icon, | |
| }, | |
| }, | |
| ), | |
| }, | |
| ); | |
| const icon = <span className="yoast-schema-blocks-icon" dangerouslySetInnerHTML= { { __html: configuration.icon } } />; | |
| configuration.icon = <BlockIcon icon={ icon }/> |
There was a problem hiding this comment.
And/or it could be made into a separate private method.
hansjovis
reviewed
Mar 31, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Test instructions
This PR can be tested by following these steps:
Impact check
*
UI changes
Quality assurance
Fixes #