Fix y-inversion bug in rounded corner rendering #2971
Draft
+129
−87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a Wayland buffer is marked as y-inverted (common with dmabuf media players and certain GPU configurations), the rounded corner clipping shader was computing coordinates in the wrong coordinate space, resulting in misaligned or upside-down corner rendering. The fix adds proper Y-axis coordinate transformation for y-inverted buffers: 1. Add ClippedSurfaceRenderElement::buffer_y_inverted() helper to detect if a render element's underlying buffer is y-inverted by querying Smithay's buffer_y_inverted() function. 2. Pass y_inverted flag to ClippedSurfaceRenderElement::new() as a parameter. 3. Apply a Y-axis flip matrix to input_to_geo when y_inverted=true: - Translate to center (0.5, 0.5) - Scale Y by -1 to flip - Translate back to original position This keeps clipping coordinates synchronized with how Smithay's renderer already handles the texture coordinates for y-inverted buffers, ensuring the shader's rounding calculations are in the correct coordinate space. Implementation required converting lazy .map() iterators to eager Vec materialization in tile.rs and mru.rs to access &mut renderer for computing the y_inverted flag. This is the standard Smithay pattern for renderer-dependent render element metadata. Fixes: Round corners render incorrectly on y-inverted buffers Tests: All 189 unit tests pass
Owner
|
What's a test client I could use for this? |
Author
|
Will have to transition to draft, my apologies. It was briefly working but something seems to have mucked it up. I typically test with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes rounded corner rendering for y-inverted Wayland buffers (dmabuf media players, certain GPU configurations).
Changes
buffer_y_inverted()helper to detect y-inverted buffers via Smithay's APIFiles Modified