Refer workspace by id #2852
Open
Refer workspace by id #2852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helcoume
reviewed
Dec 23, 2025
niri-ipc/src/lib.rs
Outdated
| } | ||
| } else { | ||
| Self::Name(s.to_string()) | ||
| if s.starts_with("id:") { |
There was a problem hiding this comment.
Using s.strip_prefix("id:") might be better here since it avoids slicing by index (s[3..])
Reduce nesting by splitting Index and Id cases into two separate if block could also be nice, but that’s probably a detail
Author
There was a problem hiding this comment.
Agreed on strip_prefix, but keep nested if for now as it would result fewer checks, let's see how others opinion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enable workspace reference by ID for operations on
niri msg action.My idea was using
id:prefix to refer workspace by its id instead of index, this is done in niri-ipc/src/lib.rs from_str trait implementation, that is checks user arguments; if it is integer number then assume user refer to index (to maintain backward compatibility of current operations); if it is prefixed byid:then assume user refering workspace's id; else assume name reference.This PR also change
niri msg workspacescommand output to include workspace's id.