Skip to content

Run client-server tests without creating Wayland sockets on disk #953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
YaLTeR opened this issue Jan 10, 2025 · 1 comment
Closed

Run client-server tests without creating Wayland sockets on disk #953

YaLTeR opened this issue Jan 10, 2025 · 1 comment
Labels
enhancement New feature or request

Comments

@YaLTeR
Copy link
Owner

YaLTeR commented Jan 10, 2025

It's unnecessary overhead, plus with enough threads it can clog up and fail the test.

Add some method on Niri or State to connect a new client, then add a flag to skip creating the file socket, then use these in cilent-server tests.
@YaLTeR YaLTeR added the enhancement New feature or request label Jan 10, 2025
r-vdp added a commit to NixOS/nixpkgs that referenced this issue Jan 12, 2025
@r-vdp
niri: avoid flaky tests
a478143 
See YaLTeR/niri#953
@r-vdp r-vdp mentioned this issue Jan 12, 2025
Merged
13 tasks
nixpkgs-ci bot pushed a commit to NixOS/nixpkgs that referenced this issue Jan 12, 2025
@r-vdp @github-actions
niri: avoid flaky tests
4126a98 
See YaLTeR/niri#953

(cherry picked from commit a478143)
@YaLTeR
Copy link
Owner Author

YaLTeR commented Jan 27, 2025

Fixed in 0226d9a

@YaLTeR YaLTeR closed this as completed Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@YaLTeR