Skip to content

#128 replace expected with assert #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
occupant23 merged 2 commits into from
Jul 27, 2020
Merged

#128 replace expected with assert #129

occupant23 merged 2 commits into from
Jul 27, 2020

Conversation

@oomelianchuk
Copy link
Contributor

@oomelianchuk oomelianchuk commented Jul 22, 2020

The only place I found, where @Test(expected =...) annotation should be replaced with Assert.assertThrows v due to risk of error masking

@oomelianchuk oomelianchuk requested a review from occupant23 July 22, 2020 11:42
@occupant23 occupant23 changed the base branch from master to develop July 27, 2020 09:04
@occupant23 occupant23 merged commit f0c4a74 into develop Jul 27, 2020
@occupant23 occupant23 deleted the #128-replace-expected-with-assert branch July 27, 2020 09:09
@occupant23 occupant23 linked an issue Jul 27, 2020 that may be closed by this pull request
Improve test code #128
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@occupant23 occupant23 occupant23 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve test code

3 participants

@oomelianchuk @occupant23