-
Notifications
You must be signed in to change notification settings - Fork 4.7k
MUX: Prevent goroutine leak #5110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
你真的可以在旧版本触发出来这些bug吗 |
this bugs appear after using Xray-core/common/mux/server.go Line 294 in ab1fa13
so we should implement "monitor" for mux-server too(when we have no session and server-mux is idle for a 60 seconds, ServerWorker should be closed, it is safe because client-mux closes after 16-seconds idle-time) /// or on the client-side, "DispatcherLink" waited on Xray-core/common/mux/client.go Line 278 in ab1fa13
but if sub-client-inbound-connection cut(with no fin-ack), the code stuck here, because now |
|
没有破坏 XUDP UoT Migration 吧 |
|
It has nothing to do with XUDP, just added "monitor" for mux-server-side. |
|
checked again and ready. |
1f02b73 to
9cca6b9
Compare
762aabc to
f0f7130
Compare
|
rebased. |
fix problems:
after using
DispatchLink, we may have goroutine-leak when connection between mux-client and mux-server cut.in some cases in mux
dispatchLinkwait on wrong things and it cause code-stuck and goroutine leak.for reverse, we may have goroutine-leak when a sub-client-connection cut
///