Skip to content

radeon: drop duplicate (and incompatible) definition of FOURCC_RGBA32#20

Open
metux wants to merge 1 commit into
masterfrom
pr/fourcc
Open

radeon: drop duplicate (and incompatible) definition of FOURCC_RGBA32#20
metux wants to merge 1 commit into
masterfrom
pr/fourcc

Conversation

@metux

@metux metux commented Oct 20, 2025

Copy link
Copy Markdown
Contributor

Already defined by the Xserver SDK, and we also should it's value instead of some entirely different one.

@metux metux requested review from a team October 20, 2025 16:43
@algrid

algrid commented Oct 20, 2025

Copy link
Copy Markdown

The value defined here seems to be for FOURCC RGBA (which can be 16 or 32bit) and the one from the Xserver (0x34325241) is actually for AR24 (it’s probably ok to call it rgba32 since it’s still the same 4byte format as far as I can guess). But all this is a bit confusing 😅

Already defined by the Xserver SDK, and we also should it's value
instead of some entirely different one.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
@metux

metux commented Dec 9, 2025

Copy link
Copy Markdown
Contributor Author

@josephcrowell

@metux

metux commented Jan 28, 2026

Copy link
Copy Markdown
Contributor Author

The value defined here seems to be for FOURCC RGBA (which can be 16 or 32bit) and the one from the Xserver (0x34325241) is actually for AR24 (it’s probably ok to call it rgba32 since it’s still the same 4byte format as far as I can guess). But all this is a bit confusing 😅

Still wondering which one is the actually correct one.

@josephcrowell

Copy link
Copy Markdown
Contributor

I just saw this. Hell I don't know either mate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants