Skip to content

upgrade hansott/psr-cookies from 2.0 to 3.0 #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 16, 2021

Conversation

pavarnos
Copy link
Contributor

https://github.com/hansott/psr7-cookies/releases/tag/3.0.0 made the upgrade pretty easy.

I was unable to test it on php 8 because composer upgrade said

  - roave/backward-compatibility-check 5.0.0 requires php ^7.4.7 -> your php version (8) does not satisfy that requirement.

The roave library is from wyrihaximus/test-utilities 3.6.2 requires roave/backward-compatibility-check (^5.0.0) , and does not yet appear to support php ^8.

@pavarnos pavarnos requested a review from WyriHaximus as a code owner March 13, 2021 20:41
@boring-cyborg boring-cyborg bot added Dependencies 📦 Pull requests that update a dependency file JSON 👨‍💼 PHP 🐘 Hypertext Pre Processor Source 🔮 Tests 🧪 labels Mar 13, 2021
@WyriHaximus
Copy link
Owner

Will have a thorough look tomorrow. FYI, and I probably should document this better, if you run make (Linux/OSX only at the moment) it will run all tests and other QA tools on 7.4. Those packages are on my radar for PHP 8 support, since they are dev dependencies they shouldn't hinder PHP 8 support in this package.

@WyriHaximus WyriHaximus added this to the 4.1.0 milestone Mar 16, 2021
Copy link
Owner

@WyriHaximus WyriHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Will release this later tonight

@WyriHaximus WyriHaximus merged commit 02ae28f into WyriHaximus:master Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies 📦 Pull requests that update a dependency file JSON 👨‍💼 PHP 🐘 Hypertext Pre Processor Source 🔮 Tests 🧪
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants