Skip to content

FED-3926 Add non-minified React 18 prod bundle #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

sydneyjodon-wk
Copy link
Collaborator

@sydneyjodon-wk sydneyjodon-wk commented Jun 18, 2025

Based on this support request, we should add a non-minified version of our React 18 prod JS bundle

Changes

  • Add non-minified react.js prod bundle
  • Add tests

QA instructions

  • CI passes
  • New tests are sufficient test coverage
  • New react.js bundle is non-minified

@sydneyjodon-wk sydneyjodon-wk marked this pull request as ready for review June 18, 2025 23:04
@sydneyjodon-wk
Copy link
Collaborator Author

sydneyjodon-wk commented Jun 18, 2025

Failing CI on Dart 3 is also happening in master #420 - looking into this separately

@btr-rmconsole-7 btr-rmconsole-7 bot changed the title Add non-minified React 18 prod bundle FED-3926 Add non-minified React 18 prod bundle Jun 18, 2025
Copy link
Collaborator

@greglittlefield-wf greglittlefield-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment; this results in non-react code, like react-redux and react-dart JS, not being minified, but unfortunately doesn't seem to affect React code.

That might be worth moving forward with, but I feel it might not provide too much value to consumers. 🤷 Thoughts?

Otherwise, all the changes look good!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was diffing this file to a formatted version of react.min.js locally, and noticed that almost all the code from React is still minified. See that diff here: https://gist.github.com/greglittlefield-wf/f3c45e0f1769170344e50266f617c479

I did a little digging, and I think it's because React pre-minifies their production bundle 😕, both for

So we might not be able to have non-minified code and production behavior at the same time after all ☹️

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oof sadness 😢

@sydneyjodon-wk sydneyjodon-wk deleted the add-non-min-prod-bundle branch June 23, 2025 23:31
@greglittlefield-wf greglittlefield-wf restored the add-non-min-prod-bundle branch July 11, 2025 23:52
@greglittlefield-wf greglittlefield-wf deleted the add-non-min-prod-bundle branch July 11, 2025 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants