-
Notifications
You must be signed in to change notification settings - Fork 68
FED-3926 Add non-minified React 18 prod bundle #419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Failing CI on Dart 3 is also happening in master #420 - looking into this separately |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment; this results in non-react code, like react-redux and react-dart JS, not being minified, but unfortunately doesn't seem to affect React code.
That might be worth moving forward with, but I feel it might not provide too much value to consumers. 🤷 Thoughts?
Otherwise, all the changes look good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was diffing this file to a formatted version of react.min.js locally, and noticed that almost all the code from React is still minified. See that diff here: https://gist.github.com/greglittlefield-wf/f3c45e0f1769170344e50266f617c479
I did a little digging, and I think it's because React pre-minifies their production bundle 😕, both for
- react:
- react-dom
So we might not be able to have non-minified code and production behavior at the same time after all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oof sadness 😢
Based on this support request, we should add a non-minified version of our React 18 prod JS bundle
Changes
react.js
prod bundleQA instructions
react.js
bundle is non-minified