Format on Dart 2.10.4, only check formatting on stable runs #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ? staticProps == null | ||
| ? null | ||
| : staticProps[memberName] | ||
| : props[memberName]; |
There was a problem hiding this comment.
This is just a formatting change
joebingham-wk
approved these changes
Nov 25, 2020
Co-authored-by: joebingham-wk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
CI was failing on every commit because the code was formatted under Dart 2.9, and CI was only skipping formatting on
devruns and not the Dart 2.10stablerun.Previously, stable runs were broken due to build issues, but now that that's fixed, we can format on stable.
Solution
QA steps