Skip to content

CPLAT-7226 Deprecate setClientConfiguration #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Feb 3, 2020
Merged

CPLAT-7226 Deprecate setClientConfiguration #253

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
47cee01
Deprecate the configuration methods
joebingham-wk Jan 27, 2020
1590bbc
Move proxies
joebingham-wk Jan 28, 2020
72e5de6
Move statics
joebingham-wk Jan 28, 2020
dfdf62b
Clean up
joebingham-wk Jan 28, 2020
c1a3535
Remove setClientConfiguration
joebingham-wk Jan 28, 2020
8c20cf2
Move synthetic events
joebingham-wk Jan 28, 2020
cc23112
Format
joebingham-wk Jan 28, 2020
1da5ffb
Make convertEventHandlers private
joebingham-wk Jan 28, 2020
a6be92b
Continue to tidy up
joebingham-wk Jan 28, 2020
a577d6b
Remove more setClientConfiguration calls
joebingham-wk Jan 28, 2020
ac22ed4
Type dom node elements as dynamic
joebingham-wk Jan 28, 2020
e3474d4
Show JsBackedMapComponentFactoryMixin
joebingham-wk Jan 28, 2020
76f0f4d
Rename react_proxies
joebingham-wk Jan 29, 2020
330d479
Update component_factory's library declaration
joebingham-wk Jan 29, 2020
f002320
Rename react_zone
joebingham-wk Jan 29, 2020
840392d
Rename component_registration_utils
joebingham-wk Jan 29, 2020
0b216c1
Rename react_statics
joebingham-wk Jan 29, 2020
958afcc
Rename sythetic_event_factories
joebingham-wk Jan 29, 2020
620e92c
Update deprecation wording
joebingham-wk Jan 29, 2020
1e0146e
Apply suggestions from code review
joebingham-wk Jan 29, 2020
7a84fa7
Format
joebingham-wk Jan 29, 2020
ea29121
Rename private utils file
joebingham-wk Jan 29, 2020
98bd551
Address Greg's feedback
joebingham-wk Feb 3, 2020
1167ad3
Format
joebingham-wk Feb 3, 2020
b7266c9
Merge branch '5.4.0-wip' of github.com:cleandart/react-dart into CPLA…
joebingham-wk Feb 3, 2020
bfd44cd
Add import
joebingham-wk Feb 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions example/js_components/js_components.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@ import 'package:react/react_client/react_interop.dart';
import 'package:react/react_dom.dart' as react_dom;

main() {
setClientConfiguration();

var content = IndexComponent({});

react_dom.render(content, querySelector('#content'));
Expand Down
3 changes: 0 additions & 3 deletions example/test/context_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,10 @@ import 'dart:html';

import 'package:react/react.dart' as react;
import 'package:react/react_dom.dart' as react_dom;
import 'package:react/react_client.dart';

import 'react_test_components.dart';

void main() {
setClientConfiguration();

react_dom.render(
react.div({}, [
react.h1({}, ['React Legacy Context API']),
Expand Down
3 changes: 0 additions & 3 deletions example/test/function_component_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import 'dart:math';
import 'package:react/hooks.dart';
import 'package:react/react.dart' as react;
import 'package:react/react_dom.dart' as react_dom;
import 'package:react/react_client.dart';

var hookTestFunctionComponent = react.registerFunctionComponent(HookTestComponent, displayName: 'useStateTest');

Expand Down Expand Up @@ -273,8 +272,6 @@ RandomUseEffectTestComponent(Map props) {
}

void main() {
setClientConfiguration();

render() {
react_dom.render(
react.Fragment({}, [
Expand Down
2 changes: 0 additions & 2 deletions example/test/react_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,10 @@
import "dart:html";

import "package:react/react_dom.dart" as react_dom;
import "package:react/react_client.dart";

import "react_test_components.dart";

void main() {
setClientConfiguration();
react_dom.render(
mainComponent({}, [
helloGreeter({'key': 'hello'}, []),
Expand Down
Loading