CPLAT-3874: Function Components #221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- required additional arg for legacy context
- used to force null returns to be javascript null, dart2js sometimes converts null to undefined and react doesn't like that, not one tiny bit.
* 5.1.0-wip: remove dart 1 from ci
kealjones-wk
changed the title
Co-Authored-By: joebingham-wk <[email protected]>
aaronlademann-wf
requested changes
Oct 29, 2019
- even though it doesn't do anything and webpack changes it back to a var anyway...
Co-Authored-By: Aaron Lademann <[email protected]>
Co-Authored-By: Aaron Lademann <[email protected]>
…leandart/react-dart into CPLAT-3874-function-components
greglittlefield-wf
requested changes
Oct 29, 2019
kealjones-wk
force-pushed
the
CPLAT-3874-function-components
branch
from
7b4e5b8 to
40b9ef2
Compare
* 5.2.0-wip: react 5.0.0 Clean up lints react 5.0.0-alpha.1 Point readme links to pub.dev urls Update ReactJS version in README
aaronlademann-wf
approved these changes
Nov 6, 2019
|
+1 refresh |
joebingham-wk
approved these changes
Nov 13, 2019
greglittlefield-wf
requested changes
Nov 13, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Support Function Components in react-dart
Changes
ReactDartFunctionComponentFactoryProxyclassregisterFunctionComponentmethodReactDartComponentFactoryProxy2'sbuildandgenerateExtendedJsPropslogic into mixin for re-use withReactDartFunctionComponentFactoryProxyisDartComponentlogic to support function components