Skip to content

get_post_galleries() : Avoid a PHP Warning when an image block doesn't contain an ID. #8992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

get_post_galleries() : Avoid a PHP Warning when an image block doesn't contain an ID. #8992

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ddb70dc
get_post_galleries() : Avoid a PHP Warning when an image block doesn'…
dd32 Jun 17, 2025
f5aedb8
Update src/wp-includes/media.php
dd32 Jun 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions src/wp-includes/media.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5298,12 +5298,17 @@ function get_post_galleries( $post, $html = true ) {
// New Gallery block format as an array.
if ( $has_inner_blocks ) {
$attrs = wp_list_pluck( $block['innerBlocks'], 'attrs' );
$ids = wp_list_pluck( $attrs, 'id' );

foreach ( $ids as $id ) {
$url = wp_get_attachment_url( $id );
$ids = array();
foreach ( $attrs as $attr ) {
if ( ! isset( $attr['id'] ) ) {
continue;
}

if ( is_string( $url ) && ! in_array( $url, $srcs, true ) ) {
$ids[] = $attr['id'];
$url = wp_get_attachment_url( $attr['id'] );

if ( $url && ! in_array( $url, $srcs, true ) ) {
$srcs[] = $url;
}
}
Expand Down
Loading