-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Icon: Add SVG files for forms and hash icons #74116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
I wonder if there are other options for the form icon? This one from Lucide is quite nice. The hash seems a little large, maybe it should have a 16px footprint like some of the other icons in the library? |
|
@jameskoster this was the I've switched to @jasmussen ngl, your proposal looks ambitious, but it could potentially generate too much discussion about whether they fit or not. To me, it looks more appropriate for a future enhancement than for what it's pretending to be now (switching from dashicons that should be eliminated to SVG). So, I tried to fit with the current set of icons as many as I could. For now, I'm just trying to triage and add these two icons to the set, with the objective of pushing the forms block out of experimental phase for 2026. Maybe a future iteration could be making a set of icons that uniformly represent each of the aspects of the form's idea. |



Referencing this PR #73996
Two new icons needed for the Forms block
formsicon adapted from the original dashicons, with 24×24 canvas and 18×18 icon maintaining the original aspect ratio.hashicon standardized with, 24×24 canvas, 18×18 icon, lines 1.5pxOnce this PR is merged, I will merge it into #73996 so we can move it forward.
cc @jameskoster @mattmiklic