Skip to content

Conversation

@SirLouen
Copy link
Member

Referencing this PR #73996

Two new icons needed for the Forms block

  • forms icon adapted from the original dashicons, with 24×24 canvas and 18×18 icon maintaining the original aspect ratio.
  • New hash icon standardized with, 24×24 canvas, 18×18 icon, lines 1.5px

Once this PR is merged, I will merge it into #73996 so we can move it forward.

cc @jameskoster @mattmiklic

@github-actions
Copy link

github-actions bot commented Dec 19, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: SirLouen <[email protected]>
Co-authored-by: jameskoster <[email protected]>
Co-authored-by: jasmussen <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions bot added the [Package] Icons /packages/icons label Dec 19, 2025
@SirLouen SirLouen added the [Type] Enhancement A suggestion for improvement. label Dec 19, 2025
@SirLouen SirLouen added the Needs Design Feedback Needs general design feedback. label Dec 19, 2025
@jameskoster jameskoster requested a review from a team December 19, 2025 10:49
@jameskoster
Copy link
Contributor

I wonder if there are other options for the form icon? This one from Lucide is quite nice.

The hash seems a little large, maybe it should have a 16px footprint like some of the other icons in the library?

@jasmussen
Copy link
Contributor

jasmussen commented Dec 19, 2025

Thanks for contributing. I'd echo Jay's point, the Lucide one is quite nice. In general I would not adapt from Dashicons, but copy an existing WordPress icon and adapt that, that way you'll get the right spacing, positioning, metrics, etc.

The hash seems useful as an icon to have, but it's not clear to me that it reads as "number input". In fact all these icons feel somewhat eclectic:

image

I know they are dashicons, but the feedback remains regardless of style: these are all icons for child blocks of the form, and I would expect them to share some visual aspects so they feel related, like they belong together. This is similar to what has been done for comment related icons:

image

Extrapolating on Jay's feedback about the Lucide icon, what you could do is take a similar approach: have a general form icon, then variants that keep the top half of that icon but substitute small details below, like letters. ASCII mockups:

Form

--
[ ]

Text

--
--- --

checkbox

--
[X]

email

--
@

email

--
#

I'd even challenge the idea that each of those child items need to have bespoke unique icons. All "title" blocks have the same icons:

image

Similarly, I could see you having a single Form icon, and a single icon for all form child blocks inside.

None of these feelings are strong, hope the advice is useful.

@SirLouen
Copy link
Member Author

@jameskoster this was the forms icon in dashicons (same name). But here is representing the checkbox input. My alternative would be calling it differently, like checkboxes.svg and maybe adding the forms.svg for the main forms icon you propose (but this will be a future PR, here I'm first working on the forms input block, not the forms block).

I've switched to checkboxes.svg the name for the forms.svg and reduced to 16px the footprint of the hash.

@jasmussen ngl, your proposal looks ambitious, but it could potentially generate too much discussion about whether they fit or not. To me, it looks more appropriate for a future enhancement than for what it's pretending to be now (switching from dashicons that should be eliminated to SVG). So, I tried to fit with the current set of icons as many as I could.

For now, I'm just trying to triage and add these two icons to the set, with the objective of pushing the forms block out of experimental phase for 2026. Maybe a future iteration could be making a set of icons that uniformly represent each of the aspects of the form's idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Design Feedback Needs general design feedback. [Package] Icons /packages/icons [Type] Enhancement A suggestion for improvement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants