Skip to content

Composer: avoid writing a lock file#2443

Merged
jrfnl merged 2 commits into
WordPress:developfrom
fredden:feature/composer.lock-false
Apr 25, 2024
Merged

Composer: avoid writing a lock file#2443
jrfnl merged 2 commits into
WordPress:developfrom
fredden:feature/composer.lock-false

Conversation

@fredden
Copy link
Copy Markdown
Contributor

@fredden fredden commented Apr 23, 2024

When working with this repository as a developer, we should be using the latest compatible packages. By writing a lock file for Composer, we may get into a state where we are "stuck" on an older version of a dependency. This change avoids such a situation by telling Composer to not write out a lock file in the project.

@jrfnl jrfnl added this to the 3.x Next milestone Apr 24, 2024
Copy link
Copy Markdown
Member

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fredden!

P.S.: the build failure is unlikely to be related to this PR. We'll merge this once that's been fixed.

@jrfnl jrfnl force-pushed the feature/composer.lock-false branch from 1e621bd to d2db21a Compare April 25, 2024 09:25
@jrfnl
Copy link
Copy Markdown
Member

jrfnl commented Apr 25, 2024

Rebased without changes to get a passing build.

@jrfnl jrfnl enabled auto-merge (squash) April 25, 2024 09:27
@jrfnl jrfnl merged commit 29488fe into WordPress:develop Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants