Sniff::has_nonce_check(): allow for comparing a variable before nonce check#1685
Merged
GaryJones merged 1 commit intoApr 2, 2019
Conversation
… check This builds onto the similar changes made for the `ValidatedSanitizedInput` sniff in ... This fixes false positives as reported in 1114 and 1506. Note: it is not currently checked that the nonce check is done within the same conditional scope as the comparison. Just that it is done within the same _function_ scope. Includes unit tests. Fixes 1114 Fixes 1506
GaryJones
approved these changes
Apr 2, 2019
GaryJones
deleted the
feature/1114-1506-nonceverification-allow-comparisons-before
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds onto the similar changes made for the
ValidatedSanitizedInputsniff in #1682.This fixes false positives as reported in #1114 and #1506.
Note: it is not currently checked that the nonce check is done within the same conditional scope as the comparison. Just that it is done within the same function scope.
Includes unit tests.
Fixes #1114
Fixes #1506