Core: forbid assignments in conditions#1661
Merged
Merged
Conversation
GaryJones
approved these changes
Mar 27, 2019
Member
|
Handbook is updated. |
As per the proposal in https://make.wordpress.org/core/2019/03/26/coding-standards-updates-for-php-5-6/ Open actions: * [x] Adjust Core PHP handbook to mention this rule in the `Clever code` section
jrfnl
force-pushed
the
feature/core-no-assignments-in-condition
branch
from
c829b63 to
cce11ae
Compare
Member
Author
|
Thanks @pento ! I've updated the PR to use the exact text from the handbook in the inline documentation, as well as changed the placement of the rule to match the order of the rules in the handbook. If there are no objections, this is ready for merge now. |
GaryJones
approved these changes
Apr 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the
WordPress.CodeAnalysis.AssignmentInConditionfrom theExtraruleset to theCoreruleset.As per the proposal in https://make.wordpress.org/core/2019/03/26/coding-standards-updates-for-php-5-6/
Open actions:
Clever codesection/cc @pento