AlternativeFunctions: allow for php://input used with file_get_contents()#1649
Merged
GaryJones merged 1 commit intoFeb 20, 2019
Conversation
Reported by remcotolsma in 49e7700#commitcomment-32391794 While a little esoteric in a WP context, using the WP File Wrapper functions is not a suitable alternative when `php://input` is being read. Includes unit test.
GaryJones
approved these changes
Feb 20, 2019
GaryJones
deleted the
feature/alternative-functions-allow-file-get-contents-input-stream
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported by @remcotolsma in 49e7700#commitcomment-32391794
While a little esoteric in a WP context, using the WP File Wrapper functions is not a suitable alternative when
php://inputis being read.Includes unit test.
Note: an issue should probably be opened to check if any other sniffs should be adjusted to account for
php://input. I have not verified this at this time, but the input validation sniff comes to mind.