Skip to content

WPCS native PHPCS ruleset: minor tweaks#1604

Merged
GaryJones merged 1 commit into
developfrom
feature/native-phpcs-ruleset-tweaks
Jan 29, 2019
Merged

WPCS native PHPCS ruleset: minor tweaks#1604
GaryJones merged 1 commit into
developfrom
feature/native-phpcs-ruleset-tweaks

Conversation

@jrfnl

@jrfnl jrfnl commented Dec 25, 2018

Copy link
Copy Markdown
Member

The basepath and parallel options were introduced in PHPCS 3.0 and can now be enabled for the WPCS native PHPCS checking.

And as WPCS 2.0.0 drops the VIP ruleset, we can now include the WordPress ruleset instead of including the WordPress-Extra + WordPress-Docs rulesets separately.

The `basepath` and `parallel` options were introduced in PHPCS 3.0 and can now be enabled for the WPCS native PHPCS checking.

And as WPCS 2.0.0 drops the `VIP` ruleset, we can now include the `WordPress` ruleset instead of including the `WordPress-Extra` + `WordPress-Docs` rulesets separately.
@GaryJones

Copy link
Copy Markdown
Member

we can now include the WordPress ruleset instead of including the WordPress-Extra + WordPress-Docs rulesets separately.

Does this not still include three less-than-ideal sniffs that aren't currently included in any of the named rulesets?

@jrfnl

jrfnl commented Dec 25, 2018

Copy link
Copy Markdown
Member Author

Does this not still include three less-than-ideal sniffs that aren't currently included in any of the named rulesets?

Good point, I'd forgotten about that.

I don't think those sniffs are problematic for our own ruleset though (the build passes after all), but it would be good to have a think about what to do with those sniffs.

Adding them to Extra seems most appropriate, though my remark about these sniffs is still valid.

Refs:

@jrfnl jrfnl modified the milestones: 2.0.0, 2.x Next Jan 14, 2019
@jrfnl

jrfnl commented Jan 28, 2019

Copy link
Copy Markdown
Member Author

Is there any reason why this PR cannot be merged ?

The above mentioned "three sniffs in WordPress, not in Extra" discussion should probably be moved to a separate issue and is not problematic for the WPCS native ruleset (which is what this PR targets).

@GaryJones GaryJones merged commit 126b2e3 into develop Jan 29, 2019
@GaryJones GaryJones deleted the feature/native-phpcs-ruleset-tweaks branch January 29, 2019 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants