Add comment in winetricks_selfupdate and winetricks_selfupdate_rollback warning of race condition#2489
Open
GideonBear wants to merge 1 commit intoWinetricks:masterfrom
Open
Conversation
GideonBear
changed the title
…ck warning of race condition
GideonBear
force-pushed
the
document-race-condition
branch
from
fe12f8a to
514f0f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
cp,>,mvacross filesystem boundaries, or other non-atomic ways of writing to a file, to overwrite a running shell script, can have catastrophic consequences (executing partial/mixed code).Upon hearing winetricks does self-updates and is written in shell, I needed to check for myself if this race condition was accounted for. It is, but possibly not consciously.
In this PR I add comments warning any potential new hands on this code of the necessity of
mvhere.