Fix tree-sitter go to definition from context menus#3350
Merged
sdottaka merged 2 commits intoApr 30, 2026
Merged
Conversation
Update right-click navigation to resolve the symbol under the mouse and prefer tagged type definitions when the position-based lookup stays on the current line.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves “Go to definition” behavior when invoked from editor context menus by aligning the caret with the right-clicked symbol and refining tree-sitter definition target selection to avoid resolving back to the clicked reference.
Changes:
- Update merge editor context-menu handling to move the caret to the mouse location before showing the menu.
- Adjust tree-sitter definition resolution to prefer tag-based targets in specific “self-resolving” cases.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| Src/MergeEditView.cpp | Moves caret/selection to the right-clicked text position prior to displaying the context menu. |
| Externals/crystaledit/editlib/TreeSitterParser.cpp | Refines FindDefinition logic to optionally prefer tag-definition targets over position-based targets in certain cases. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
Could you please take a look at the Copilot review and fix any issues if needed? |
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary