Fix incorrect GetAsyncKeyState usage for modifier key detection#3257
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes modifier-key detection by updating GetAsyncKeyState checks to correctly test the high-order bit (key currently down), preventing false positives caused by the low-order “pressed since last call” bit.
Changes:
- Update
VK_SHIFTchecks from truthiness toGetAsyncKeyState(VK_SHIFT) < 0in merge-mode key handlers. - Update
VK_CONTROLchecks from truthiness toGetAsyncKeyState(VK_CONTROL) < 0in merge-mode key handlers. - Fix Shift+Delete detection in
CSuperComboBox::PreTranslateMessageto only trigger when Shift is actually held.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Src/WebPageDiffFrm.cpp | Corrects Shift/Ctrl detection in web diff merge-mode key handling. |
| Src/MergeEditView.cpp | Corrects Shift/Ctrl detection in editor merge-mode key handling. |
| Src/ImgMergeFrm.cpp | Corrects Shift/Ctrl detection in image merge-mode key handling. |
| Src/Common/SuperComboBox.cpp | Corrects Shift detection for Shift+Delete behavior while dropdown is open. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.