Skip to content

Add SHA256 checksum verification for CFR JAR download#3243

Merged
sdottaka merged 1 commit into
WinMerge:masterfrom
Gaurav-pasi:feature/cfr-java-decompiler-plugin
Mar 10, 2026
Merged

Add SHA256 checksum verification for CFR JAR download#3243
sdottaka merged 1 commit into
WinMerge:masterfrom
Gaurav-pasi:feature/cfr-java-decompiler-plugin

Conversation

@Gaurav-pasi

Copy link
Copy Markdown
Contributor

Summary

  • Add SHA256 checksum verification for downloaded CFR JAR using CertUtil, consistent with other plugin download scripts (yq, PlantUML, java, etc.)
  • Delete the downloaded file on checksum mismatch to prevent executing unverified JARs
  • Fix the incorrect SHA256 hash value to match the actual cfr-0.152.jar release
  • Fix minor grammar in the DecompileJVM plugin documentation

Context

Follow-up to #3242 -- addresses the review feedback from @sdottaka about missing SHA256 verification for the downloaded CFR JAR file.

Test plan

  • Verified correct SHA256 hash of cfr-0.152.jar downloaded from GitHub releases matches the updated value
  • Verified CertUtil hash check returns True for the real JAR
  • Verified CertUtil hash check returns False for a tampered/fake file
  • Verified implementation pattern matches existing scripts (yq.bat, q.bat, PlantUML.bat, etc.)

Verify downloaded cfr.jar against expected SHA256 hash using CertUtil,
consistent with other plugin download scripts (yq, PlantUML, etc.).
Delete the file on checksum mismatch to prevent executing unverified JARs.
Also fix minor grammar in plugin documentation.
@sdottaka sdottaka merged commit d28d436 into WinMerge:master Mar 10, 2026
2 checks passed
@sdottaka

Copy link
Copy Markdown
Member

Thank you!

@sdottaka sdottaka added this to the v2.16.55 milestone Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants