Make replace and replaceWithList case-insensitive#3222
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request modifies the replace and replaceWithList filter expression functions to perform case-insensitive search and replacement. The changes convert string literals into pre-compiled regex patterns with the RE_CASELESS flag, enabling case-insensitive matching while preserving performance through optimization.
Changes:
- Introduced
escapeRegexhelper function to escape special regex characters from literal strings - Modified
replacefunction to use regex-based matching with case-insensitive flag - Updated
replaceWithListandLoadListto pre-compile regex patterns for better performance - Enhanced
FunctionNode::Optimizeto pre-compile regex patterns at optimization time
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| Src/FilterEngine/ReplaceList.cpp | Updated LoadList to compile regex patterns with RE_CASELESS flag for case-insensitive replacement |
| Src/FilterEngine/FilterExpressionNodes.cpp | Added escapeRegex helper, modified ReplaceFunc and ReplaceWithListFunc to support case-insensitive regex matching, enhanced Optimize to pre-compile patterns |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
…nctions (#3223) * Initial plan * Add case-insensitive tests for replace and replaceWithList functions Co-authored-by: sdottaka <98126+sdottaka@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: sdottaka <98126+sdottaka@users.noreply.github.com>
Contributor
… in lambda (#3224) * Initial plan * Fix lambda capturing local regex by reference: use shared_ptr by value Co-authored-by: sdottaka <98126+sdottaka@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: sdottaka <98126+sdottaka@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
replaceandreplaceWithListperform case-insensitive search and replacement.