Add logInfo, logWarn, logError functions to filter expressions#3131
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds three logging functions (logInfo, logWarn, logError) to WinMerge's filter expression system for debugging purposes. These functions concatenate and output their arguments to the log at different severity levels and return the last argument value, allowing them to be used inline within filter expressions.
Changes:
- Added C++ implementation of logging functions with string conversion support for various value types
- Updated logger signature to accept severity levels (error, warning, info)
- Added comprehensive documentation in English, Japanese, and Hebrew
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| Src/FilterEngine/FilterExpressionNodes.cpp | Implements ToStringValue helper and three logging functions (LogError, LogWarn, LogInfo) with function registration |
| Src/FilterEngine/FilterExpression.h | Updates logger signature to accept level parameter |
| Src/FilterEngine/FilterExpression.cpp | Updates logger calls to include level parameter |
| Src/DirDoc.cpp | Updates logger initialization to route messages by level |
| Translations/Docs/Manual/*.po | Updates translation files with new line number references |
| Docs/Manual/*/Filters.xml | Adds documentation for the new logging functions with examples |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds three logging functions (
logInfo,logWarn,logError) to filter expressions for debugging purposes.Changes
New Functions:
logInfo(value1, value2, ...)- logs at information levellogWarn(value1, value2, ...)- logs at warning levellogError(value1, value2, ...)- logs at error levelFeatures:
Usage Examples
logInfo("File size:", Size) > 1MBSize > 1KB and logInfo("Large file:", Name) contains "test"logWarn("Processing:", Name) like "*.tmp"