fix(validators): reject certain paths from being used #17330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds validation to reject filenames that start with directories from the translation-finder blacklist (such as .git, .svn, etc.). The goal is to prevent potentially dangerous file paths from being used in Weblate's file handling operations, aligning with the existing is_excluded function used for zip extraction.
Key Changes:
- Imports
EXCLUDESfromtranslation_finder.finderto use as a path exclusion list - Adds a validation check in
validate_filenameto reject paths starting with prohibited folders - Adds a test case to verify
.git/configis rejected
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| weblate/utils/validators.py | Imports EXCLUDES and adds validation logic to reject filenames starting with prohibited folders |
| weblate/utils/tests/test_validators.py | Adds test case verifying that .git/config raises a ValidationError |
nijel
commented
Dec 16, 2025
nijel
force-pushed
the
validate-filename
branch
from
a3d3bcb to
d865984
Compare
Restrict based on the translation-finder blacklist which covers files we do not want to touch.
nijel
force-pushed
the
validate-filename
branch
from
d865984 to
0e8e80c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restrict based on the translation-finder blacklist which covers files we do not want to touch.