Skip to content
This repository was archived by the owner on Dec 22, 2021. It is now read-only.

Fix to_hex_string for I8 and I16 #320

Merged
merged 1 commit into from
Aug 25, 2020
Merged

Fix to_hex_string for I8 and I16 #320

merged 1 commit into from
Aug 25, 2020

Conversation

ngzhian
Copy link
Member

@ngzhian ngzhian commented Aug 24, 2020

Print out the full i32 hex string, then extract the lower 2 or 4 chars.

@ngzhian
Fix to_hex_string for I8 and I16
6a85501 
Print out the full i32 hex string, then extract the lower 2 or 4 chars.
binji
binji approved these changes Aug 25, 2020
View reviewed changes
Copy link
Member

@binji binji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but is there a test for this?

@ngzhian
Copy link
Member Author

ngzhian commented Aug 25, 2020

Yes there is, running test/core/run.py on one of the simd wast files (forgot which ones, probably any i8x16 ones) will fail.

Right now we don't run any simd test, I will put up a change to change our Makefile/runner to also run those tests.

@ngzhian ngzhian merged commit b7aea06 into WebAssembly:master Aug 25, 2020
@ngzhian ngzhian deleted the fix-hex-i8-i16 branch August 25, 2020 22:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@binji binji binji approved these changes

Assignees
No one assigned
Labels
interpreter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ngzhian @binji