Implement SIMD load splat and load extend #306
Conversation
Introduce a new SimdLoad AST node to represent SIMD load splat and load extend. The existing parameters for loadop is not sufficient to represent all the load splats and extends, as it only has 3 pack sizes, and 2 sign-extensions, and 1 none case, giving at total of 7 cases: - sz = (pack_size * extension) option while we have 6 load extends and 4 load splats (10 in total). We can add 1 more case to pack_size, Pack64, which will only be used by SIMD loads, but that still only gives 8 cases. We can also add 1 more data type to extension, that will give us enough, but it will be useless for non-v128 loads.
|
This is more for a RFC than a ready for review PR. I wrote down the issues in the description of this PR. I would really like to reuse |
There was a problem hiding this comment.
Yes, I think it makes sense to have separate SimdLoad/Store instructions. Case in point: the reftypes extension already changes the def of memop to only carry a num_type instead of a value_type.
However, instead of introducing another auxiliary type, I'd just introduce SimdLoad (which corresponds to regular loads) and SimdLoadSplat (which doesn't have a non-SIMD equivalent).
OTOH, it seems fine to extend the pack_size type to include Pack64 and avoid an extra type for SIMD.
This enables running all the SIMD tests (in test/core/simd) whenever we do `make test`. This should not be submitted yet, it depends on WebAssembly#306 or WebAssembly#307 for the implementation of load splats and loads extends.
|
Closed in favor of #307 |
This enables running all the SIMD tests (in test/core/simd) whenever we do `make test`. This should not be submitted yet, it depends on WebAssembly#306 or WebAssembly#307 for the implementation of load splats and loads extends.
Introduce a new SimdLoad AST node to represent SIMD load splat and load
extend. The existing parameters for loadop is not sufficient to
represent all the load splats and extends, as it only has 3 pack sizes,
and 2 sign-extensions, and 1 none case, giving at total of 7 cases:
while we have 6 load extends and 4 load splats (10 in total).
We can add 1 more case to pack_size, Pack64, which will only be used by
SIMD loads, but that still only gives 8 cases. We can also add 1 more
data type to extension, that will give us enough, but it will be useless
for non-v128 loads.