This repository was archived by the owner on Apr 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 36
Adds explanatory prose related to delegate
.
#246
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves the last three so far unaddressed `todo::` sections: - Add prose explaining try-delegate's jump. - Adds prose and intuition for delegating exception handlers. + Also a minor modification to the prose of catching exception handlers, that somewhat reduces calling the administrative instruction by its identifier (CAUGHTadm) in the prose.
rossberg
reviewed
Dec 15, 2022
rossberg
reviewed
Dec 15, 2022
document/core/exec/runtime.rst
Outdated
.. todo:: | ||
Add prose for delegating handlers. | ||
Delegating handlers start with the identifier |DELEGATEadm| and carry a label index, | ||
indicating the outer block in which any caught exceptions will be thrown (delegated to). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my email suggestion regarding a slight refactor of this syntax.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Co-authored-by: Andreas Rossberg <[email protected]>
…to delegate-descriptions
ioannad
added a commit
to ioannad/exception-handling
that referenced
this pull request
Feb 15, 2023
as it doesn't make sense on its own in WebAssembly#246.
takikawa
approved these changes
Feb 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the last three so far unaddressed
todo::
sections: