Test suite doesn't work with new versions of wabt (assert_return_{canonical,arithmetic}_nan)

[rianhunter]

New versions of wabt reject spec test assertions assert_return_canonical_nan and assert_return_arithmetic_nan since WebAssembly/wabt@415c3bb. This repo still uses those old assertions and doesn't work with current versions of wabt anymore.

Ideally wabt wouldn't have removed support for those old commands, since the only way to fix this repo is to break backward compatibility with older versions of wabt.

[sbc100]

I don't see any occurrences of assert_return_canonical_nan or assert_return_arithmetic_nan in this repo.

wabt passes all the tests in the repo (which are mirrored in https://github.com/WebAssembly/testsuite/tree/master/proposals/bulk-memory-operations)

Am I missing something?

[rianhunter]

Hmm there are many such examples. Here is one:

bulk-memory-operations/test/core/f64.wast

Line 91 in ffdbb6e

(assert_return_canonical_nan (invoke "add" (f64.const -0x0.0000000000001p-1022) (f64.const -nan)))

[sbc100]

Oh I see the problem. I'm only looking at the actual bulk memory tests because the testsuite repo only includes tests that have be modified from upstream:
https://github.com/WebAssembly/testsuite/tree/master/proposals/bulk-memory-operations

The solution I think is simply to merge the latest upstream changes into this repo.

[binji]

It's a fair point that it would be possible to keep assert_return_*_nan working in wabt too, since we keep get_local, anyfunc etc. as well. That said, I think @sbc100 is right that the fix here is to merge from upstream spec.