[Stack Switching] Simplify clearing of continuation store in the fuzzer #7871
+58
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlively
reviewed
Aug 28, 2025
src/tools/execution-results.h
Outdated
| FunctionResult run(Function* func, Module& wasm, ModuleRunner& instance) { | ||
| // Clear the continuation state before each run of an export. This is | ||
| // simpler than doing so in all the exceptional circumstances below. | ||
| instance.clearContinuationStore(); |
There was a problem hiding this comment.
Alternatively, we could use a tiny RAII struct here and maintain the nice invariant that everything is cleaned before this function exits.
tlively
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C++ lacks try-finally, so clear the continuation store before calling
exports in the fuzzer, not after. This ensures we don't miss anything.
Also remove an entirely unused function, that was confusing
during debugging.