Skip to content

sample download progress bar and skip user prompt #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2021
Merged

sample download progress bar and skip user prompt #81

merged 1 commit into from
Sep 22, 2021

Conversation

Johansmm
Copy link
Contributor

Update BaseDataset to:

  • Show progress bar while a sample is downloading.
  • Skip "Do you want to download and use a sample?" if name not in possible samples. Now, the workflow directly make the following user prompt: "Please write a new root directory for {self.name} dataset: "

Closes #75

@Johansmm Johansmm added enhancement New feature or request alodataset labels Sep 21, 2021
@Johansmm Johansmm requested a review from thibo73800 September 21, 2021 15:21
@Johansmm Johansmm self-assigned this Sep 21, 2021
@thibo73800 thibo73800 merged commit be14d67 into master Sep 22, 2021
@thibo73800
Copy link
Contributor

Thanks for the feature ! However, unit test do not pass anymore using the new samples

@Johansmm Johansmm mentioned this pull request Sep 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thibo73800 thibo73800 Awaiting requested review from thibo73800

Assignees

@Johansmm Johansmm

Labels
alodataset enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bar progress in samples download
2 participants
@Johansmm @thibo73800