Skip to content

fix incompatibilites lightning1.9 #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 13, 2023
Merged

fix incompatibilites lightning1.9 #328

merged 5 commits into from
Mar 13, 2023

Conversation

anhtu293
Copy link
Contributor

General description of your pull request with the list of new features and/or bugs.

  • Fix bug 1 : MetricsCallback and run_pl_training
  • on_train_batch_end hook doesnt require dataloader_idx now.
  • FitLoop object of pytorch-lightning doesnt have public property should_accumulate since version 1.5.0
  • run_pl_training: pytorch-lightning changes the initialization method of Trainer, especially for multi-gpu training.

This pull request includes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@anhtu293 anhtu293 added bug Something isn't working alonet labels Mar 13, 2023
@anhtu293 anhtu293 requested a review from Data-Iab March 13, 2023 10:18
@anhtu293 anhtu293 self-assigned this Mar 13, 2023
@Data-Iab Data-Iab merged commit e504d78 into dev Mar 13, 2023
@anhtu293 anhtu293 mentioned this pull request Mar 15, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Data-Iab Data-Iab Data-Iab approved these changes

Assignees

@anhtu293 anhtu293

Labels
alonet bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anhtu293 @Data-Iab