-
Notifications
You must be signed in to change notification settings - Fork 6
allow batch_list to batch tensors with different children #304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- throwing an error for unmergeable children with None would break the current behavior, that motivated the creation of unmergeable children in the first place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you provide this PR with a new set of unit test to check compatibility with previous behavior + exposing the different new possible scenarios ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested.
Will be merged once @thibo73800 approves
@Data-Iab Unittests have been added ; and an error fixed. The branch is now ready to be merged. |
Add an argument to
aloscene.batch_list
, allowing to batch tensors with different children or properties with different values.Closes #272
Here, the
baseline
property has different values for different tensors. Therefore, the property baseline of the batched tensors hasbaseline
set toNone
.Only one of the two frames has a disparity child, therefore the batched tensor will have
disparity
set toNone
Note: this will not drop unmergeable children, because by definition they allow that some tensors have
None
values for a child before mergingThis pull request includes