alobugdays : added usable test split to CocoBaseDataset #247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anhtu293
reviewed
Nov 17, 2022
alodataset/coco_base_dataset.py
Outdated
| @@ -341,7 +355,12 @@ def __call__(self, image, target): | |||
|
|
|||
|
|
|||
| if __name__ == "__main__": | |||
| coco_dataset = CocoBaseDataset(sample=True) | |||
| coco_dataset = CocoBaseDataset(sample=False,img_folder = "test2017") | |||
There was a problem hiding this comment.
Coding convention:
- A comma "," should be followed by a space
- There are no space before and after "="
alodataset/coco_base_dataset.py
Outdated
| @@ -231,7 +238,14 @@ def getitem(self, idx): | |||
| return BaseDataset.__getitem__(self, idx) | |||
|
|
|||
| image_id = self.items[idx] | |||
| if "test" in self.img_folder: | |||
| #get the filename from image_id without relying on annotation file | |||
| frame = Frame(os.path.join(self.img_folder, f'{str(image_id). zfill(12)}.jpg')) | |||
There was a problem hiding this comment.
- There shouldnt be a space " " after str(image_id).
- double quote sign " " is prefered for string in aloception-oss.
anhtu293
approved these changes
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue :
#234
Minimal reproducible example : in the main()